Skip to content

QA Efficiency: Extend available track cuts#1024

Merged
njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:nj-dpg
Jul 19, 2022
Merged

QA Efficiency: Extend available track cuts#1024
njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:nj-dpg

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio

Copy link
Copy Markdown
Collaborator Author

Thanks to @zhangbiao-phy for triggering this!

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator

Thanks to @zhangbiao-phy for triggering this!

Thank to you!

@njacazio

Copy link
Copy Markdown
Collaborator Author

@zhangbiao-phy could you maybe try this code to check that it gives what you expect ? Then we can merge

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator

@zhangbiao-phy could you maybe try this code to check that it gives what you expect ? Then we can merge

Hi @njacazio, looks good, however when I compile the new version, I meet an error: "/Users/zbiao/alice/sw/SOURCES/O2Physics/master/0/DPG/Tasks/qaEfficiency.cxx:1023:21: error: cannot initialize a variable of type 'char *const' with an rvalue of type 'const char *'"

@mfaggin

mfaggin commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

@zhangbiao-phy could you maybe try this code to check that it gives what you expect ? Then we can merge

Hi @njacazio, looks good, however when I compile the new version, I meet an error: "/Users/zbiao/alice/sw/SOURCES/O2Physics/master/0/DPG/Tasks/qaEfficiency.cxx:1023:21: error: cannot initialize a variable of type 'char *const' with an rvalue of type 'const char *'"

try to swap const char* to char* const or viceversa and in case push the change

@njacazio

Copy link
Copy Markdown
Collaborator Author

Yes, I will have this in another PR, it does not make sense to have it in this one, apologies

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator

Hi @njacazio @mfaggin, It's Ok for me. I think we can go ahead. Thanks a lot!

@njacazio njacazio enabled auto-merge (squash) July 19, 2022 17:50

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 08a1711 into AliceO2Group:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants